[Solar-talk] Re: [Solar-svn] Revision 3037 (a.k.a page black-list)
Antti Holvikari
anttih at gmail.com
Sat Mar 22 13:41:21 CDT 2008
On Sat, Mar 22, 2008 at 7:34 PM, <pmjones at solarphp.com> wrote:
> Solar_Controller_Front: [ADD] Per conversation with Antti Holvikari, add a 'diabled' config key to list class names that should be treated as 'not-found'. This will help to keep base classes from being invoked.
>
Ok, so I think we still have a problem. Actually two:
1. The black-list is for class names which means that Vendor_App_Base
is different than Solar_App_Base. **Every** vendor that has a base app
class needs to add that to the list **in addition** to Solar_App_Base.
I suggest that the list is for page names. This way `base` covers 99%
of the cases.
2. I'd very much prefer to have the error handling in a page
controller than in the front itself. The front now just runs
_notFound() which prints this simple 404 page. Instead, let the front
run my default page controller and I'll then see what I can do with
the request. This will most likely run _notFound() in the **page**
controller, which actually makes perfect sense.
Hope these make sense.
--
Antti Holvikari <http://anttih.com>
More information about the Solar-talk
mailing list