[Solar-talk] Move Solar.php to Solar/Solar.php ?
Andreas Ravnestad
andreas.ravnestad at gmail.com
Wed Sep 5 16:09:35 CDT 2007
Paul M Jones wrote:
> Hi all --
>
> Antti (or was it Andreas?) brought this issue up on IRC a while back,
> as did Mike Naberezny some months ago. I think I can address it with
> an exception to the coding standards for just this one case.
>
> The issue is: it's hard to do an SVN "external" of Solar, because
> externals only work with directories, and the Solar.php file lives
> outside the main Solar directory.
>
> I'm suggesting that maybe we move from "include 'Solar.php'" to
> "include 'Solar/Solar.php'". This does break the class-to-file naming
> convention rather dramatically, and raises a single highly-visible
> inconsistency in the project. However, I think that for those folks
> using Subversion externals to manage their code base, that this would
> be a small change with a very positive effect. In general, we only
> include Solar.php in the bootstrap file, so it's not a change that
> would affect wide swaths of code.
>
> I'm not saying "this is going to happen" but it is one possible
> solution to that (perhaps uncommon) problem.
>
> Does anyone here have arguments for or against this kind of move?
> (Does anyone really care?)
I'd rather se Clay's suggestion implemented. However, both breaks 100%
of all Solar apps out there, and in addition it will introduce 1)
breakage of class-to-file naming convention XOR 2) more verbosity (for
example, Solar_Base vs. Solar).
And since this would benefit *only* the crazy gangsters who uses the svn
code, I have to say -1 to making this change.
Instead I suggest a (new) pear-channel with nightly/hourly builds from svn.
-Andreas
More information about the Solar-talk
mailing list