[Solar-talk] Move Solar.php to Solar/Solar.php ?

[Antti Holvikari]

On 9/5/07, Paul M Jones <pmjones at solarphp.com> wrote:
> Hi all --
>
> Antti (or was it Andreas?) brought this issue up on IRC a while back,
> as did Mike Naberezny some months ago.  I think I can address it with
> an exception to the coding standards for just this one case.
>
> The issue is: it's hard to do an SVN "external" of Solar, because
> externals only work with directories, and the Solar.php file lives
> outside the main Solar directory.
>
> I'm suggesting that maybe we move from "include 'Solar.php'" to
> "include 'Solar/Solar.php'".  This does break the class-to-file
> naming convention rather dramatically, and raises a single highly-
> visible inconsistency in the project.  However, I think that for
> those folks using Subversion externals to manage their code base,
> that this would be a small change with a very positive effect.  In
> general, we only include Solar.php in the bootstrap file, so it's not
> a change that would affect wide swaths of code.
>
> I'm not saying "this is going to happen" but it is one possible
> solution to that (perhaps uncommon) problem.
>
> Does anyone here have arguments for or against this kind of move?
> (Does anyone really care?)

Interesting.

Yes, I have Solar as svn:externals, and yes, it's a pain in the ass.
Right now I have manually added Solar.php to my repo.

I hate to brake the rules. Maybe we should rename the class?
Solar_BaseStatic? Solar_TheRealDeal?

-- 
Antti Holvikari