[Solar-talk] Solar_Http_Response and check-headers-sent

[Paul M Jones]

On Jun 1, 2007, at 3:26 PM, Antti Holvikari wrote:

> On 6/1/07, Paul M Jones <pmjones at ciaweb.net> wrote:
>> On Jun 1, 2007, at 12:08 PM, Antti Holvikari wrote:
>>>
>>> We know for a fact that headers need to be checked within our normal
>>> browser responses back to our browser, but when making HTTP requests
>>> within your apps the headers must *not* be checked because they have
>>> nothing to do with my apps response headers to the browser (vs. the
>>> headers of my "home made" HTTP request's response object).
>>>
>>> In that example I gave, Response::setHeader() should *not* check for
>>> headers because the headers *can't* have been sent. But headers back
>>> to the browser could have been sent already.
>>
>> Ah yes, I see your point.  It seems from this that the only time
>> Response should check if headers have been sent is at
>> Response::display() time.  Would that be a good fix here?
>
> Yes, that sounds good :-). Dude, thanks a lot.

Committed, and thank *you* for the good suggestion.  :-)

Hope this helps, and let me know if anything else needs attention.




--

Paul M. Jones  <http://paul-m-jones.com>

Solar: Simple Object Library and Application Repository
for PHP5.  <http://solarphp.com>

Join the Solar community wiki!  <http://solarphp.org>

Savant: The simple, elegant, and powerful solution for
templates in PHP.  <http://phpsavant.com>