[Solar-talk] request object

Jeff Surgeson solar at 3hex.com
Wed Sep 27 15:19:01 PDT 2006


> > However in Solar_Content_Abstract a new request object is created
> > each time
> > access is needed to a server request, for example,
> >
> > $request = Solar::factory('Solar_Request')
> > $data['editor_ipaddr'] = $request->server('REMOTE_ADDR');
>
> It might be that I shouldn't be doing that at all to begin with; I'll
> take another look.
>
> But yes, you're right, it'd be more efficient to create it the one
> time as a property and then access it when needed.
>
> Thanks for pointing this out to me, I'm betting I need to remove that
> from the content domain model classes.

It was more ignorance than me noticing anything wrong, it looked like just two 
ways to achieve the same thing and wanted to know if one was more correct 
than the other.

But if it helped then my quest is at an end, I can now go to bed! :-)

Oh and thanks for the latest release, great stuff, also I for one, from a 
selfish point of view am happy you dropped the dev branch, it just makes 
things simpler :-)

-- 
Jeff Surgeson / South Africa


More information about the solar-talk mailing list