[Solar-talk] Solar_Model_Tags::asString() bug
Antti Holvikari
anttih at gmail.com
Tue May 16 22:42:24 PDT 2006
On 5/16/06, Paul M Jones <pmjones at solarphp.com> wrote:
>
> On May 16, 2006, at 3:03 PM, Antti Holvikari wrote:
>
> > Hi all!
> >
> > There's a bug with asString(). $tmp is not defined on line 66 if $tags
> > is an array.
> >
> > Solution: change $tmp on line 66 to $tags. :-)
>
> Good catch!
>
> How'd you happen to find that one?
I'm using it :-), but more on that later ;-)
It's really amazing how clean the code is. This is the first bug that
I found and I've been doing alot of Solar stuff lately. Solar-beta
anyone? :-)
Also, I'm sure if you had written a Unit test for Solar_Model_Tags,
you'd have found that bug. The power of unit-tests!
BTW. Solar_Test* kicks ass! Even PHPUnit's! :-)
--
Antti Holvikari <http://antti.dotgeek.org/blog>
Zend Certified Engineer (ZCE)
More information about the solar-talk
mailing list