[Solar-svn] Revision 3169

[pmjones at solarphp.com]

updated comments


Modified: trunk/Solar/Sql/Model/Cache.php
===================================================================
--- trunk/Solar/Sql/Model/Cache.php	2008-05-20 15:50:14 UTC (rev 3168)
+++ trunk/Solar/Sql/Model/Cache.php	2008-05-20 15:50:49 UTC (rev 3169)
@@ -184,7 +184,7 @@
     
     /**
      * 
-     * Fetchs the data for a cache entry.
+     * Fetches the data for a cache entry.
      * 
      * @param string $key The cache entry key.
      * 

Modified: trunk/Solar/Sql/Model/Record.php
===================================================================
--- trunk/Solar/Sql/Model/Record.php	2008-05-20 15:50:14 UTC (rev 3168)
+++ trunk/Solar/Sql/Model/Record.php	2008-05-20 15:50:49 UTC (rev 3169)
@@ -925,6 +925,11 @@
      * they never are null (although strictly speaking you do *not* need to 
      * define them as NOT NULL).
      * 
+     * N.b.: This **will not** clear the cache for the model, since it uses
+     * direct SQL to effefct the increment.  Thus, you will need to clear the
+     * cache manually if you want to the incremented values to show up from
+     * the cache.
+     * 
      * @param string $col The column to increment.
      * 
      * @param int|float $amt The amount to increment by (default 1).

Modified: trunk/Solar/Sql/Select.php
===================================================================
--- trunk/Solar/Sql/Select.php	2008-05-20 15:50:14 UTC (rev 3168)
+++ trunk/Solar/Sql/Select.php	2008-05-20 15:50:49 UTC (rev 3169)
@@ -1038,8 +1038,10 @@
             // add each of the columns from the source, deconflicting
             // along the way.
             foreach ($source['cols'] as $col) {
-        
-                // does it use a function?
+                
+                // does it use a function?  we don't care if it's the first
+                // char, since a paren in the first position means there's no
+                // function name before it.
                 $parens = strpos($col, '(');
                 
                 // choose our column-name deconfliction strategy